Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add depends_on section for peers which are using CouchDb #435

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

sroopsai
Copy link
Contributor

@sroopsai sroopsai commented Apr 8, 2024

No description provided.

Signed-off-by: roopsai surampudi <roopsai@outlook.in>
@sroopsai sroopsai force-pushed the sroopsai/issue434 branch from 350f2e1 to 72c0079 Compare April 8, 2024 05:27
@dzikowski
Copy link
Contributor

Thanks a lot @sroopsai for handling this!

CI tests fail, because you need to also update snapshots. Just run locally:

npm run test:e2e-update

And commit changes. Fablo doesn't have local dev docs with that information yet (sorry for that). I've just created an issue to handle that: #436.

Signed-off-by: roopsai surampudi <roopsai@outlook.in>
@sroopsai sroopsai changed the title Add depends_on section for peers which are using Couch Add depends_on section for peers which are using CouchDb Apr 8, 2024
@dzikowski dzikowski enabled auto-merge April 9, 2024 14:39
@dzikowski dzikowski merged commit 4ae85cb into hyperledger-labs:main Apr 9, 2024
4 of 7 checks passed
@dzikowski
Copy link
Contributor

@sroopsai I have to revert that PR, it seems the depends_on it in wrong place. I didn't notice it before.

In docker-compose.yaml, after line 282, we should have:

    <%_ if(peer.db.type==="CouchDb") { _%>
    depends_on:
      couchdb.<%= peer.name %>.<%= org.domain %>:
        condition: service_healthy
    <%_ } _%>

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants